Skip to content

Enable allow-partial-results to Yarn V1 dependencies map construction #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
eranturgeman merged 10 commits into from
Nov 11, 2024
Merged

Enable allow-partial-results to Yarn V1 dependencies map construction #229

eranturgeman merged 10 commits into from
Nov 11, 2024

Conversation

@eranturgeman
Copy link
Contributor

@eranturgeman eranturgeman commented Nov 7, 2024 •
edited
Loading

  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....
  • All static analysis checks passed.
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • Updated the Contributing page / ReadMe page / CI Workflow files if needed.
  • All changes are detailed at the description. if not already covered at JFrog Documentation, new documentation have been added.

This change support the new 'allow-partial-results' support in Yarn V1 dependencies map construction:
jfrog/build-info-go#282

@eranturgeman eranturgeman added ignore for release Automatically generated release notes safe to test Approve running integration tests on a pull request labels Nov 7, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 7, 2024
@eranturgeman eranturgeman mentioned this pull request Nov 10, 2024
Merged
4 tasks
@eranturgeman
go mod
cc9745f
@eranturgeman
Merge branch 'dev' of https://github.com/jfrog/jfrog-cli-security int…
bbaa5ca 
…o apply-allow-partial-results-on-yarn-dep-tree-construction
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Nov 10, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 10, 2024
@eranturgeman eranturgeman mentioned this pull request Nov 10, 2024
Merged
4 tasks
attiasas
attiasas approved these changes Nov 10, 2024
View reviewed changes
Copy link
Contributor

@attiasas attiasas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, maybe make sure we have a tests case to catch this case

@eranturgeman
Merge branch 'dev' of https://github.com/jfrog/jfrog-cli-security int…
c2e9a07 
…o apply-allow-partial-results-on-yarn-dep-tree-construction
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Nov 10, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 10, 2024
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Nov 10, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 10, 2024
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Nov 11, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 11, 2024
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Nov 11, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 11, 2024
@github-actions
Copy link

github-actions bot commented Nov 11, 2024

👍 Frogbot scanned this pull request and did not find any new security issues.

@github-actions
Copy link

github-actions bot commented Nov 11, 2024

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/jfrog/jfrog-cli-security/commands/audit/sca/yarn 0.00% (ø)
github.com/jfrog/jfrog-cli-security/jas 0.00% (ø)
github.com/jfrog/jfrog-cli-security/utils 0.00% (ø)
Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/jfrog/jfrog-cli-security/commands/audit/sca/yarn/yarn.go 0.00% (ø) 0 0 0
github.com/jfrog/jfrog-cli-security/jas/analyzermanager.go 0.00% (ø) 0 0 0
github.com/jfrog/jfrog-cli-security/utils/auditbasicparams.go 0.00% (ø) 0 0 0

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

@eranturgeman eranturgeman merged commit 49fd385 into jfrog:dev Nov 11, 2024
barv-jfrog pushed a commit to barv-jfrog/jfrog-cli-security that referenced this pull request Nov 11, 2024
@eranturgeman @barv-jfrog
Enable allow-partial-results to Yarn V1 dependencies map construction (…
7604a33 
…jfrog#229)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@attiasas attiasas attiasas approved these changes

Assignees

No one assigned

Labels

ignore for release Automatically generated release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eranturgeman @attiasas